Skip to content

Commit 32415bb

Browse files
Merge pull request #1712 from vijayphoenix:version
PiperOrigin-RevId: 303147970
2 parents 7b7dc3a + 5d17fb8 commit 32415bb

File tree

1 file changed

+16
-7
lines changed

1 file changed

+16
-7
lines changed

tensorflow_datasets/scripts/download_and_prepare.py

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -176,12 +176,19 @@ def main(_):
176176
datasets_to_build = set(FLAGS.datasets and FLAGS.datasets.split(",")
177177
or tfds.list_builders())
178178
datasets_to_build -= set(FLAGS.exclude_datasets.split(","))
179-
version = "experimental_latest" if FLAGS.experimental_latest_version else None
180-
logging.info("Running download_and_prepare for datasets:\n%s",
179+
180+
# Only pass the version kwargs when required. Otherwise, `version=None`
181+
# overwrite the version parsed from the name.
182+
# `tfds.builder('my_dataset:1.2.0', version=None)`
183+
if FLAGS.experimental_latest_version:
184+
version_kwarg = {"version": "experimental_latest"}
185+
else:
186+
version_kwarg = {}
187+
188+
logging.info("Running download_and_prepare for dataset(s):\n%s",
181189
"\n".join(datasets_to_build))
182-
logging.info('Version: "%s"', version)
183190
builders = {
184-
name: tfds.builder(name, data_dir=FLAGS.data_dir, version=version)
191+
name: tfds.builder(name, data_dir=FLAGS.data_dir, **version_kwarg)
185192
for name in datasets_to_build
186193
}
187194

@@ -197,7 +204,7 @@ def main(_):
197204
config = builder.BUILDER_CONFIGS[FLAGS.builder_config_id]
198205
logging.info("Running download_and_prepare for config: %s", config.name)
199206
builder_for_config = tfds.builder(
200-
builder.name, data_dir=FLAGS.data_dir, config=config, version=version)
207+
builder.name, data_dir=FLAGS.data_dir, config=config, **version_kwarg)
201208
download_and_prepare(builder_for_config)
202209
else:
203210
for name, builder in builders.items():
@@ -206,8 +213,10 @@ def main(_):
206213
# requested, then compute all.
207214
for config in builder.BUILDER_CONFIGS:
208215
builder_for_config = tfds.builder(
209-
builder.name, data_dir=FLAGS.data_dir, config=config,
210-
version=version)
216+
builder.name,
217+
data_dir=FLAGS.data_dir,
218+
config=config,
219+
**version_kwarg)
211220
download_and_prepare(builder_for_config)
212221
else:
213222
# If there is a slash in the name, then user requested a specific

0 commit comments

Comments
 (0)