-
Notifications
You must be signed in to change notification settings - Fork 1.6k
visual support for object detection dataset #1639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR.
@Conchylicultor I have made some major changes in the structure of the module as you had suggested. There is one main file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update. There seems to be a lot of duplicated code, making it harder to maintain. Could you re-factor in smaller functions reused across modules to avoid duplication ?
@Conchylicultor I have made changes according to your suggestions. Created an Could you suggest some methods to reuse the code inside the build function? I was thinking of using python decorators but that would certainly increase the code complexity quite a bit. |
Update: I checked my code on wider_faces dataset as well. It is working fine, added that to the colab notebook for demonstration. I have also added a |
@Conchylicultor Some structural changes in the code. The In the In the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update! This looks better
@Conchylicultor I have also overridden |
Also added |
I ended up refactoring myself the visualization to make it more extensible: https://github.com/tensorflow/datasets/pull/1728/files |
…detection datasets
Since I encountered some git errors, I had to force push. Everything is ok now/ |
Added visualization support for object detection dataset.
Issue Link: Link
Procedure:
We only take the first Sequence feature, first bbox feature and first label feature for now.
Notebook demonstration: Link