Sanitize the extensions of URLs with query parameters correctly #3859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this fix, the extension is taken from the path of the URL instead of the complete URL. The previous implementation would erroneously search for an extension in the query and params part of the URL. Additionally, a mistake is fixed where very long "extensions" could have the returned path break the max_length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix, the extension is taken from the path of the URL instead of the complete
URL. The previous implementation would erroneously search for an extension in the query
and params part of the URL. Additionally, a mistake is fixed where very long "extensions"
could have the returned path break the max_length.
Best,
Marten