Update audio_spec.py #339
Open
Update audio_spec.py #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the potential "nan" problem of the precrocess_model in BrowserFftSpec
shaoyijia
requested review from
MarkDaoust,
wolffg and
yashk2810
as code owners
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
google-cla
bot
added
cla: yes
wangtz
previously approved these changes
Aug 3, 2021
| @@ -283,6 +283,8 @@ def _split(self, wav, label): | |||
| ]) | |||
| def _preprocess(self, x, label): | |||
| """Preprocess the dataset to extract the spectrum.""" | |||
| # Add small Gaussian noise to the input x to solve the potential "nan" problem of the preprocess_model | |||
There was a problem hiding this comment.
Please wrap this line. Python code is expected to have a max len = 80.
google-ml-butler
bot
added
kokoro:force-run
shaoyijia
force-pushed
the
EchoShao8899-fix-nan-problem
branch
from
2d684f6 to
5d039b7
Compare
The preprocess_model will produce "nan" results when input tensors contain too many zero entries. Such inputs are common because there may be delays in recording devices resulting in an empty stream at the beginning of the audio file. This problem is fixed here by adding small Gaussian noise to the inputs before they go through the preprocess_model.
wangtz
approved these changes
Aug 3, 2021
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preprocess_model used by BrowserFftSpec will produce "nan" results when the input tensors contain too many zero entries. Such inputs are common because there may be delays in the recording devices resulting in an empty stream at the beginning of the audio file. This PR fixes this potential "nan" problem by adding a small Gaussian noise to the inputs before they go through the preprocess_model.