copy license files #304
Closed
copy license files #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liss-h
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Hi, sorry I talked with alex and after thinking about it it does not make sense to copy the license files here, because this is not our complete dependency graph (and it might change through overrides).
So this probably does not make sense here. But please double check that the serd license file is copied properly into the conan package (and that is has a good name, something like LICENSE_serd or something)
|
superseded by #325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #78
why double copy?
At the moment, this information should only be used in generate() and validate() methods.(https://docs.conan.io/2/reference/conanfile/methods/generate.html)