-
Notifications
You must be signed in to change notification settings - Fork 10
Single null node representation #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It might make sense to also modify the comparison functions. I'm pretty sure it will also work like this but it would be cleaner |
I have updated the design to address the concerns (description is also updated), please have another look @nkaralis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Found only some typos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes. I only have one question
Close #321
Design
Node::is_{literal,iri,..}
now returnTriBool
. If the node is null:TriBool::Err
is returned, otherwise the function reports the type as before.{Literal,IRI,BlankNode,Variable}::is_{literal,iri,..}
are now deleted, as it does not make sense to call them if you already know the concrete type of the node.POBR
This is not a POBR breaking change under the assumption that null-nodes are never persisted.