Skip to content

Conversation

liss-h
Copy link
Collaborator

@liss-h liss-h commented Oct 28, 2024

Close #321

Design

  • null node's backend id is all zeros. This happens to be the blank node repr, but that doesn't matter (see following points)
  • Node::is_{literal,iri,..} now return TriBool. If the node is null: TriBool::Err is returned, otherwise the function reports the type as before.
  • {Literal,IRI,BlankNode,Variable}::is_{literal,iri,..} are now deleted, as it does not make sense to call them if you already know the concrete type of the node.

POBR

This is not a POBR breaking change under the assumption that null-nodes are never persisted.

@liss-h liss-h requested a review from nkaralis October 28, 2024 12:23
@liss-h
Copy link
Collaborator Author

liss-h commented Oct 28, 2024

It might make sense to also modify the comparison functions. I'm pretty sure it will also work like this but it would be cleaner

@liss-h liss-h requested a review from bigerl October 28, 2024 15:29
@liss-h liss-h added the not pobr breaking change Not a breaking change for Persisted Object Binary Representation even if the workflow says so label Oct 29, 2024
@liss-h
Copy link
Collaborator Author

liss-h commented Oct 29, 2024

I have updated the design to address the concerns (description is also updated), please have another look @nkaralis

@liss-h liss-h requested a review from nkaralis October 29, 2024 15:06
@bigerl bigerl requested a review from mcb5637 November 4, 2024 09:56
Copy link
Collaborator

@mcb5637 mcb5637 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Found only some typos.

Copy link
Contributor

@nkaralis nkaralis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes. I only have one question

@liss-h liss-h merged commit 8935c03 into develop Nov 5, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not pobr breaking change Not a breaking change for Persisted Object Binary Representation even if the workflow says so
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NULL nodes
4 participants