Skip to content

Conversation

liss-h
Copy link
Collaborator

@liss-h liss-h commented Mar 6, 2025

Add ostream operator overloads for storage ids.
This makes debugging easier.

@liss-h liss-h added the not pobr breaking change Not a breaking change for Persisted Object Binary Representation even if the workflow says so label Mar 6, 2025
@liss-h liss-h marked this pull request as ready for review March 10, 2025 08:25
@bigerl bigerl requested a review from mcb5637 March 10, 2025 09:42
Copy link
Collaborator

@mcb5637 mcb5637 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The code looks good, just missing some test cases for them.

@liss-h
Copy link
Collaborator Author

liss-h commented Mar 10, 2025

While writing the tests I noticed that the ID representation was very long in some cases, so I've removed the name in front of the IDs (since that should always be easy to determine from context)

@liss-h liss-h requested a review from mcb5637 March 10, 2025 11:25
@liss-h liss-h merged commit 9d1818e into develop Mar 10, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not pobr breaking change Not a breaking change for Persisted Object Binary Representation even if the workflow says so
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants