Skip to content

Fix: mac compat of NodeBackendID cast #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2025
Merged

Fix: mac compat of NodeBackendID cast #358

merged 2 commits into from
Apr 23, 2025

Conversation

liss-h
Copy link
Collaborator

@liss-h liss-h commented Apr 16, 2025 •
edited
Loading

On mac uintptr_t and uint64_t are distinct types even though they have the same size. This causes issues in some of our projects

@liss-h liss-h added the not pobr breaking change Not a breaking change for Persisted Object Binary Representation even if the workflow says so label Apr 16, 2025
bigerl
bigerl requested changes Apr 23, 2025
View reviewed changes
Copy link
Collaborator

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR. Looks good to me. I would just consider to move the testing into the hpp file as it can be done in a static_assert.

@liss-h liss-h requested a review from bigerl April 23, 2025 08:25
@liss-h liss-h merged commit 3938872 into develop Apr 23, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigerl bigerl bigerl approved these changes

Assignees
No one assigned
Labels
not pobr breaking change Not a breaking change for Persisted Object Binary Representation even if the workflow says so
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liss-h @bigerl