Skip to content

Add dataset load integration test #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 2, 2025
Merged

Add dataset load integration test #373

merged 4 commits into from
Jun 2, 2025

Conversation

mcb5637
Copy link
Collaborator

@mcb5637 mcb5637 commented May 26, 2025

close #350

@mcb5637 mcb5637 marked this pull request as ready for review May 26, 2025 14:25
@mcb5637 mcb5637 requested a review from liss-h May 26, 2025 14:25
liss-h
liss-h requested changes May 27, 2025
View reviewed changes
Copy link
Collaborator

@liss-h liss-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I think we should also test quad data and use the appropriate load_rdf_data functions instead of the parser directly

@mcb5637 mcb5637 requested a review from liss-h May 30, 2025 12:26
liss-h
liss-h reviewed Jun 2, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@mcb5637 mcb5637 requested a review from liss-h June 2, 2025 09:23
@liss-h liss-h changed the title load dataset for integration test Add dataset load integration test Jun 2, 2025
@liss-h liss-h merged commit 582903c into develop Jun 2, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liss-h liss-h liss-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dataset load tests
2 participants
@mcb5637 @liss-h