fix: Allow additional EFS volumes without enable_efs=true #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efs=true This is required to allow mounting any arbitrary paths for atlantis features like team_authz, or webhooks. These are things that are global settings so they should not be part of any particular github repo that uses atlantis.
armyers
changed the title
armyers
changed the title
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This PR was automatically closed because of stale in 10 days |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to allow mounting any arbitrary paths for atlantis features like team_authz, or webhooks, without needing to set
enable_efs=true. These are settings that are global so they should not be part of any particular github repo that uses atlantis.Description
Only required modifying on line in main.tf to allow additional volumes if the volume name is not "efs"
Motivation and Context
My use-case is that I need to add a team_authz script to control permissions for who can run TF apply on prod deployments. The script cannot go in a specific repo, and I didn't want to build it into a custom atlantis image. This fixes issue #408 .
Breaking Changes
None.
How Has This Been Tested?
I've tested it in our company environment and it works great.