Skip to content

feat: Add support for restartPolicy #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 16, 2024
Merged

feat: Add support for restartPolicy #231

merged 4 commits into from
Sep 16, 2024

Conversation

psantus
Copy link

@psantus psantus commented Sep 16, 2024

Description

ECS now supports the ability to restart containers when they crash.

Supporting documentation:

Motivation and Context

Fixes #230

Breaking Changes

Shouldn't be breaking as older terraform provider versions will just ignore restartPolicy and a default value is provided with enabled = false (default behaviour when it's absent)

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@psantus psantus marked this pull request as draft September 16, 2024 13:06
@psantus
Copy link
Author

psantus commented Sep 16, 2024

Test screnshot

@psantus psantus marked this pull request as ready for review September 16, 2024 13:31
@psantus
Copy link
Author

psantus commented Sep 16, 2024

It now works fine (fixed the validation test on var.restart_policy)

@bryantbiggs bryantbiggs changed the base branch from master to wip/v6 September 16, 2024 14:21
@psantus
Copy link
Author

psantus commented Sep 16, 2024

@bryantbiggs is the "Optional object type attributes are experimental" fail a problem? I believe it's long been in Terraform core (since 1.3)

@bryantbiggs
Copy link
Member

bryantbiggs commented Sep 16, 2024

it was introduced in Terraform 1.3, but on main we only support Terraform 1.0 and hence the failure (edit - on main we provide support up to a MSV of 1.0)

@bryantbiggs bryantbiggs merged commit 2abd25f into terraform-aws-modules:wip/v6 Sep 16, 2024
2 checks passed
@psantus psantus deleted the feat/implement-restart-policy branch September 16, 2024 15:14
@psantus
Copy link
Author

psantus commented Sep 16, 2024

Cheers @bryantbiggs.
Do you have an ETA for v6?

@RRosalia
Copy link

This is amazing! When will a new tag release be done? So we can start using it?

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we support RestartPolicy
3 participants