From 977c18be659f6f43db705452b573528fe4509d43 Mon Sep 17 00:00:00 2001 From: Maciej Malek Date: Mon, 4 Aug 2025 09:26:53 +0200 Subject: [PATCH 1/2] Updated incorrect and misleading description --- modules/container-definition/variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/container-definition/variables.tf b/modules/container-definition/variables.tf index c32ec33..82e451b 100644 --- a/modules/container-definition/variables.tf +++ b/modules/container-definition/variables.tf @@ -423,7 +423,7 @@ variable "cloudwatch_log_group_class" { } variable "cloudwatch_log_group_retention_in_days" { - description = "Number of days to retain log events. Default is 30 days" + description = "Number of days to retain log events. Set to `0` to keep logs indefinitely" type = number default = 14 } From 7ad8aa2dff05a5fc59ce7573c861b77e7dc8ac06 Mon Sep 17 00:00:00 2001 From: Maciej Malek Date: Mon, 4 Aug 2025 21:10:14 +0200 Subject: [PATCH 2/2] README updated --- modules/container-definition/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/container-definition/README.md b/modules/container-definition/README.md index 665c1c4..db723f5 100644 --- a/modules/container-definition/README.md +++ b/modules/container-definition/README.md @@ -142,7 +142,7 @@ No modules. | [cloudwatch\_log\_group\_class](#input\_cloudwatch\_log\_group\_class) | Specified the log class of the log group. Possible values are: `STANDARD` or `INFREQUENT_ACCESS` | `string` | `null` | no | | [cloudwatch\_log\_group\_kms\_key\_id](#input\_cloudwatch\_log\_group\_kms\_key\_id) | If a KMS Key ARN is set, this key will be used to encrypt the corresponding log group. Please be sure that the KMS Key has an appropriate key policy (https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/encrypt-log-data-kms.html) | `string` | `null` | no | | [cloudwatch\_log\_group\_name](#input\_cloudwatch\_log\_group\_name) | Custom name of CloudWatch log group for a service associated with the container definition | `string` | `null` | no | -| [cloudwatch\_log\_group\_retention\_in\_days](#input\_cloudwatch\_log\_group\_retention\_in\_days) | Number of days to retain log events. Default is 30 days | `number` | `14` | no | +| [cloudwatch\_log\_group\_retention\_in\_days](#input\_cloudwatch\_log\_group\_retention\_in\_days) | Number of days to retain log events. Set to `0` to keep logs indefinitely | `number` | `14` | no | | [cloudwatch\_log\_group\_use\_name\_prefix](#input\_cloudwatch\_log\_group\_use\_name\_prefix) | Determines whether the log group name should be used as a prefix | `bool` | `false` | no | | [command](#input\_command) | The command that's passed to the container | `list(string)` | `null` | no | | [cpu](#input\_cpu) | The number of cpu units to reserve for the container. This is optional for tasks using Fargate launch type and the total amount of `cpu` of all containers in a task will need to be lower than the task-level cpu value | `number` | `null` | no |