Skip to content

feat: Support for Security Hub #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Mar 12, 2025
Merged

feat: Support for Security Hub #242

merged 29 commits into from
Mar 12, 2025

Conversation

kaykhan
Copy link
Contributor

@kaykhan kaykhan commented Nov 15, 2024

Description

Adding support for parsing of security hub messages into a readable slack message.

{
  "detail-type": ["Security Hub Findings - Imported"],
  "source": ["aws.securityhub"]
}

image

Examples:
image

image

Motivation and Context

#207
#221

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@kaykhan kaykhan changed the title Support for Security Hub feat: Support for Security Hub Nov 15, 2024
@bryantbiggs bryantbiggs marked this pull request as draft November 15, 2024 15:58
@kaykhan kaykhan marked this pull request as ready for review December 2, 2024 09:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jan 2, 2025
@kaykhan
Copy link
Contributor Author

kaykhan commented Jan 2, 2025

This is ready for a review

@github-actions github-actions bot removed the stale label Jan 3, 2025
@bryantbiggs
Copy link
Member

CI failed check needs to be remediated

@kaykhan
Copy link
Contributor Author

kaykhan commented Jan 7, 2025 •
edited
Loading

CI failed check needs to be remediated

Fixed the majority of them - some of the linting issue i believe are not a result of my changes. Especially

/notify_slack.py:506:1: C901 'get_slack_message_payload' is too complex (11)

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Feb 7, 2025
@kaykhan
Copy link
Contributor Author

kaykhan commented Feb 7, 2025

Not stale: Looking for feedback on what to do regarding the changes that were made outside of this PR which are breaking the CI

@github-actions github-actions bot removed the stale label Feb 8, 2025
@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 11, 2025
@kaykhan
Copy link
Contributor Author

kaykhan commented Mar 11, 2025

Not stale: Looking for feedback on what to do regarding the changes that were made outside of this PR which are breaking the CI

@bryantbiggs
Copy link
Member

Not stale: Looking for feedback on what to do regarding the changes that were made outside of this PR which are breaking the CI

Fix it?

@kaykhan
Copy link
Contributor Author

kaykhan commented Mar 11, 2025

@bryantbiggs I misunderstood the error message given by flake8. Refactoring parsing of the notification into a dedicated function should resolve the complexity error.

@github-actions github-actions bot removed the stale label Mar 12, 2025
bryantbiggs
bryantbiggs approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit 3aef5ba into terraform-aws-modules:master Mar 12, 2025
8 checks passed
antonbabenko pushed a commit that referenced this pull request Mar 12, 2025
@semantic-release-bot
chore(release): version 6.6.0 [skip ci]
0a6a45e 
## [6.6.0](v6.5.2...v6.6.0) (2025-03-12)

### Features

* Support for Security Hub ([#242](#242)) ([3aef5ba](3aef5ba))
@antonbabenko
Copy link
Member

This PR is included in version 6.6.0 🎉

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaykhan @bryantbiggs @antonbabenko