Skip to content

Commit 63449c4

Browse files
committed
default null for maintenance_configuration and add documentation link for permissions
1 parent d139564 commit 63449c4

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

examples/table-bucket/main.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ module "kms" {
123123
description = "Key example for s3 table buckets"
124124
deletion_window_in_days = 7
125125

126+
# https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-tables-kms-permissions.html
126127
key_statements = [
127128
{
128129
sid = "s3TablesMaintenancePolicy"

modules/table-bucket/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ No modules.
3838
| <a name="input_create"></a> [create](#input\_create) | Whether to create s3 table resources | `bool` | `true` | no |
3939
| <a name="input_create_table_bucket_policy"></a> [create\_table\_bucket\_policy](#input\_create\_table\_bucket\_policy) | Whether to create s3 table bucket policy | `bool` | `false` | no |
4040
| <a name="input_encryption_configuration"></a> [encryption\_configuration](#input\_encryption\_configuration) | Map of encryption configurations | `any` | `null` | no |
41-
| <a name="input_maintenance_configuration"></a> [maintenance\_configuration](#input\_maintenance\_configuration) | Map of table bucket maintenance configurations | `any` | `{}` | no |
41+
| <a name="input_maintenance_configuration"></a> [maintenance\_configuration](#input\_maintenance\_configuration) | Map of table bucket maintenance configurations | `any` | `null` | no |
4242
| <a name="input_table_bucket_name"></a> [table\_bucket\_name](#input\_table\_bucket\_name) | Name of the table bucket. Must be between 3 and 63 characters in length. Can consist of lowercase letters, numbers, and hyphens, and must begin and end with a lowercase letter or number | `string` | `null` | no |
4343
| <a name="input_table_bucket_override_policy_documents"></a> [table\_bucket\_override\_policy\_documents](#input\_table\_bucket\_override\_policy\_documents) | List of IAM policy documents that are merged together into the exported document. In merging, statements with non-blank `sid`s will override statements with the same `sid` | `list(string)` | `[]` | no |
4444
| <a name="input_table_bucket_policy"></a> [table\_bucket\_policy](#input\_table\_bucket\_policy) | Amazon Web Services resource-based policy document in JSON format | `string` | `null` | no |

modules/table-bucket/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ variable "encryption_configuration" {
1919
variable "maintenance_configuration" {
2020
description = "Map of table bucket maintenance configurations"
2121
type = any
22-
default = {}
22+
default = null
2323
}
2424

2525
variable "create_table_bucket_policy" {

wrappers/table-bucket/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module "wrapper" {
66
create = try(each.value.create, var.defaults.create, true)
77
create_table_bucket_policy = try(each.value.create_table_bucket_policy, var.defaults.create_table_bucket_policy, false)
88
encryption_configuration = try(each.value.encryption_configuration, var.defaults.encryption_configuration, null)
9-
maintenance_configuration = try(each.value.maintenance_configuration, var.defaults.maintenance_configuration, {})
9+
maintenance_configuration = try(each.value.maintenance_configuration, var.defaults.maintenance_configuration, null)
1010
table_bucket_name = try(each.value.table_bucket_name, var.defaults.table_bucket_name, null)
1111
table_bucket_override_policy_documents = try(each.value.table_bucket_override_policy_documents, var.defaults.table_bucket_override_policy_documents, [])
1212
table_bucket_policy = try(each.value.table_bucket_policy, var.defaults.table_bucket_policy, null)

0 commit comments

Comments
 (0)