-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat: Add bucket versioning status as an output #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add bucket versioning status as an output #350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@kunickiaj Please fix the failing CI before the merge. |
5f3875c to
44e2667
Compare
manually updated to match, i think. might be some version mismatch. locally terraform-docs is outputting a different order. |
|
@kunickiaj Something is not right there still. |
When creating replicated buckets, expose a versioning status output in order to be able to create a dependency on replica buckets being ready (versioning enabled). Otherwise applying replication rules targeting a bucket which isn't fully set up may fail. Signed-off-by: Adam Kunicki <adam.kunicki@airbnb.com>
44e2667 to
72eaef8
Compare
|
fairly certain this should be correct |
## [5.3.0](v5.2.0...v5.3.0) (2025-08-05) ### Features * Add bucket versioning status as an output ([#350](#350)) ([525f43c](525f43c))
|
This PR is included in version 5.3.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
When creating replicated buckets, expose a versioning status output in order to be able to create a dependency on replica buckets being ready (versioning enabled). Otherwise applying replication rules targeting a bucket which isn't fully set up may fail.
Motivation and Context
There is no data source for bucket versioning status or exposed attributes for versioning except the
aws_s3_bucket_versioningresource which is currently encapsulated by this module.Take the following (abbreviated) example:
This may result in:
The hope is that by depending on the versioning resource could delay replication rule creation until the destination bucket is ready (and has versioning configuration fully applied).
Breaking Changes
No breaking changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request