Skip to content

Conversation

paikend
Copy link
Contributor

@paikend paikend commented Aug 21, 2025

Pull Request Description

Description

Added s3_bucket_tags_all output to enable validation of S3 bucket tags in Terraform tests. This output exposes the complete tag set applied to S3 buckets for testing purposes.

Motivation and Context

The existing outputs.tf file was missing the tags_all output, which is required for tag validation in Terraform tests. This change enables automated validation of required tags as part of the CI/CD pipeline.

Breaking Changes

This is a non-breaking change as it only adds a new output without modifying existing functionality.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Added a simple test case to validate that the Environment tag exists on S3 buckets:

run "validate_s3_required_tags" {
  command = plan
  
  assert {
    condition     = alltrue([for bucket in module.s3_bucket : contains(keys(bucket.s3_bucket_tags_all), "Environment")])
    error_message = "S3 Bucket is missing required 'Environment' tag."
  }
}

This test ensures that all S3 buckets have the required Environment tag applied.

@paikend paikend changed the title Update outputs.tf feat: Update outputs.tf Aug 21, 2025
@paikend paikend changed the title feat: Update outputs.tf feat: Add tas_all in output.tf Aug 26, 2025
@bryantbiggs
Copy link
Member

thank you, but we don't output that computed only value in our modules

@paikend
Copy link
Contributor Author

paikend commented Aug 27, 2025

thank you, but we don't output that computed only value in our modules
Ok, retried
#355 (comment)

antonbabenko pushed a commit that referenced this pull request Aug 27, 2025
antonbabenko pushed a commit that referenced this pull request Aug 27, 2025
## [5.7.0](v5.6.0...v5.7.0) (2025-08-27)

### Features

* Add tags in output.tf [#355](#355) ([#357](#357)) ([4586f12](4586f12))
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants