Skip to content

feat: update DAs to allign with best practices #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025
Merged

feat: update DAs to allign with best practices #207

merged 3 commits into from
Jun 27, 2025

Conversation

akocbek
Copy link
Contributor

@akocbek akocbek commented Jun 26, 2025

Description

  • Improve DA user experience
  • apply code engine DA rally findings
  • Review DA inputs to align with best practices

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@akocbek akocbek requested a review from shemau as a code owner June 26, 2025 18:47
@akocbek
Copy link
Contributor Author

akocbek commented Jun 26, 2025

/run pipeline

@rajatagarwal-ibm
Copy link
Member

I haven't reviewed it, but I saw it failed due to prefix length. Here's the issue https://github.ibm.com/GoldenEye/issues/issues/13599, which has details on enhanced DA user experience, that includes setting up the prefix.

Copy link

@whoffler whoffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akocbek
Copy link
Contributor Author

akocbek commented Jun 27, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Jun 27, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Jun 27, 2025

│ Error: You are not authorized to access the specified resource. See https://cloud.ibm.com/docs/Registry?topic=Registry-troubleshoot-resource
│ 
│   with module.namespace.ibm_cr_namespace.cr_namespace[0],
│   on .terraform/modules/namespace/main.tf line 11, in resource "ibm_cr_namespace" "cr_namespace":
│   11: resource "ibm_cr_namespace" "cr_namespace" {
│ 
╵}

@akocbek
Copy link
Contributor Author

akocbek commented Jun 27, 2025

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Jun 27, 2025

/run pipeline

@ocofaigh ocofaigh merged commit f735036 into main Jun 27, 2025
2 checks passed
@ocofaigh ocofaigh deleted the update_da branch June 27, 2025 14:38
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 4.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants