Skip to content

fix: update the reference-architectures #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2024
Merged

fix: update the reference-architectures #582

merged 5 commits into from
Apr 16, 2024

Conversation

Aashiq-J
Copy link
Member

@Aashiq-J Aashiq-J commented Apr 4, 2024

Description

Issue: #580

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aashiq-J Aashiq-J requested a review from SirSpidey April 4, 2024 04:24
@Aashiq-J
Copy link
Member Author

Aashiq-J commented Apr 4, 2024

/run pipeline

Copy link
Contributor

@SirSpidey SirSpidey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proactively updating these @Aashiq-J!

Some very small suggestions. One important one is not to use COS. Use Object Storage or IBM Cloud Object Storage.

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J Aashiq-J requested a review from SirSpidey April 16, 2024 04:04
@ocofaigh
Copy link
Contributor

Since Allen is unavailable this week, I'm going to approve and merge this. If any follow up actions, lets get them into a new issue

@ocofaigh ocofaigh mentioned this pull request Apr 16, 2024
@ocofaigh ocofaigh dismissed SirSpidey’s stale review April 16, 2024 11:51

changes addressed

@ocofaigh ocofaigh merged commit ae50250 into main Apr 16, 2024
@ocofaigh ocofaigh deleted the ref-arch branch April 16, 2024 11:52
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 8.1.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants