Skip to content

Commit 8247228

Browse files
authored
feat: The COS KMS auth policy created by the DA is now scoped to the exact KMS key. NOTE: When upgrading from an old version, the auth policy will be re-created, however it will be non disruptive as it will create the new policy before removing the old one (#324)
1 parent 2c411ea commit 8247228

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

.secrets.baseline

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"files": "go.sum|^.secrets.baseline$",
44
"lines": null
55
},
6-
"generated_at": "2023-12-13T05:17:42Z",
6+
"generated_at": "2023-12-14T05:17:42Z",
77
"plugins_used": [
88
{
99
"name": "AWSKeyDetector"

solutions/standard/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ locals {
249249
module "cos" {
250250
count = local.create_cos_bucket ? 1 : 0
251251
source = "terraform-ibm-modules/cos/ibm"
252-
version = "8.12.0"
252+
version = "8.14.1"
253253
create_cos_instance = var.existing_cos_instance_crn == null ? true : false
254254
create_cos_bucket = local.create_cos_bucket
255255
existing_cos_instance_id = var.existing_cos_instance_crn

tests/pr_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,8 @@ func TestRunUpgradeDASolution(t *testing.T) {
210210
"resource_group_name": options.Prefix,
211211
"region": region,
212212
"existing_kms_instance_crn": permanentResources["hpcs_south_crn"],
213-
"kms_endpoint_url": permanentResources["hpcs_south_private_endpoint"],
213+
"kms_endpoint_url": permanentResources["hpcs_south_public_endpoint"],
214+
"kms_endpoint_type": "public",
214215
"management_endpoint_type_for_bucket": "public",
215216
}
216217

0 commit comments

Comments
 (0)