Skip to content

fix: use CRN in #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2024
Merged

fix: use CRN in #222

merged 3 commits into from
Jun 17, 2024

Conversation

shemau
Copy link
Contributor

@shemau shemau commented Jun 14, 2024

Description

When creating a COS bucket, the encryption key CRN can be passed an existing KMS key ID. It requires a CRN.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau shemau requested review from Ak-sky and Aashiq-J as code owners June 14, 2024 15:49
@shemau
Copy link
Contributor Author

shemau commented Jun 14, 2024

/run pipeline

@ocofaigh
Copy link
Contributor

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Jun 16, 2024

/run pipeline

@ocofaigh ocofaigh merged commit d386fdd into main Jun 17, 2024
@ocofaigh ocofaigh deleted the crn-to-id branch June 17, 2024 08:51
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants