fix: added prefix validation

[kierramarie]

Description

Added validation to check for proper prefix. The COS module has limit on the prefix, so each module that uses the COS module needs to adapt to this limit.

Git Issue: terraform-ibm-modules/terraform-ibm-cos#770

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[kierramarie]

/run pipeline

.

[kierramarie]

/run pipeline

[kierramarie]

/run pipeline

[kierramarie]

/run pipeline

[kierramarie]

/run pipeline

[Ak-sky]

/run pipeline

[Ak-sky]

@kierramarie, can you please link the related github issue in the PR template and other missing info.

[Ak-sky]

CRA scan failed with below error

Plan: 1 to add, 0 to change, 0 to destroy.
╷
│ Error: Invalid function argument
│ 
│   on variables.tf line 53, in variable "prefix":
│   53:         length(regexall("^.*--.*", var.prefix)) == 0
│     ├────────────────
│     │ while calling regexall(pattern, string)
│     │ var.prefix is null
│ 
│ Invalid value for "string" parameter: argument must not be null.
╵

Error: Process completed with exit code 1.

[kierramarie]

/run pipeline

[kierramarie]

/run pipeline

[kierramarie]

/run pipeline

[kierramarie]

/run pipeline

[shemau]

LGTM

[shemau]

Change to the DA will require a release, so I selected minor release.

This is the latest version of the regex which should overcome the previously reported 'argument must not be null'.

I have approved this change in a number of other DAs, so I have approved this one as well.

[terraform-ibm-modules-ops]

🎉 This PR is included in version 1.17.2 🎉

The release is available on:

• GitHub release
• v1.17.2

Your semantic-release bot 📦🚀