fix: remove invalid variation (#672)

daniel-butler-irl · web-flow · commit c58e926d6bca · 2025-05-09T11:23:40.000+01:00
* remove invalid variation

* update the rotation interval to 3 months

* remove interval override
diff --git a/.catalog-onboard-pipeline.yaml b/.catalog-onboard-pipeline.yaml
@@ -12,9 +12,3 @@ offerings:
         scc:
           instance_id: 1c7d5f78-9262-44c3-b779-b28fe4d88c37
           region: us-south
-      - name: security-enforced
-        mark_ready: true
-        install_type: fullstack
-        scc:
-          instance_id: 1c7d5f78-9262-44c3-b779-b28fe4d88c37
-          region: us-south
diff --git a/ibm_catalog.json b/ibm_catalog.json
@@ -183,8 +183,7 @@
               "key": "keys"
             },
             {
-              "key": "rotation_interval_month",
-              "default_value": 3
+              "key": "rotation_interval_month"
             },
             {
               "key": "kms_endpoint_type",
diff --git a/solutions/fully-configurable/variables.tf b/solutions/fully-configurable/variables.tf
@@ -88,7 +88,7 @@ variable "key_protect_access_tags" {
 variable "rotation_interval_month" {
   type        = number
   description = "Specifies the key rotation time interval in months. Possible values: `1` through `12`. Applies only if an existing Key Protect or Hyper Protect Crypto Services instance is not specified."
-  default     = 12
+  default     = 3
 }
 
 ########################################################################################################################
diff --git a/solutions/security-enforced/variables.tf b/solutions/security-enforced/variables.tf
@@ -78,7 +78,7 @@ variable "key_protect_access_tags" {
 variable "rotation_interval_month" {
   type        = number
   description = "Specifies the key rotation time interval in months. Possible values: `1` through `12`. Applies only if an existing Key Protect or Hyper Protect Crypto Services instance is not specified."
-  default     = 12
+  default     = 3
 }
 
 ########################################################################################################################

Original file line number	Diff line number	Diff line change
`@@ -183,8 +183,7 @@`
`183`	`183`	`"key": "keys"`
`184`	`184`	`},`
`185`	`185`	`{`
`186`		`- "key": "rotation_interval_month",`
`187`		`- "default_value": 3`
	`186`	`+ "key": "rotation_interval_month"`
`188`	`187`	`},`
`189`	`188`	`{`
`190`	`189`	`"key": "kms_endpoint_type",`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ variable "key_protect_access_tags" {`
`88`	`88`	`variable "rotation_interval_month" {`
`89`	`89`	`type = number`
`90`	`90`	description = "Specifies the key rotation time interval in months. Possible values: `1` through `12`. Applies only if an existing Key Protect or Hyper Protect Crypto Services instance is not specified."
`91`		`- default = 12`
	`91`	`+ default = 3`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`########################################################################################################################`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ variable "key_protect_access_tags" {`
`78`	`78`	`variable "rotation_interval_month" {`
`79`	`79`	`type = number`
`80`	`80`	description = "Specifies the key rotation time interval in months. Possible values: `1` through `12`. Applies only if an existing Key Protect or Hyper Protect Crypto Services instance is not specified."
`81`		`- default = 12`
	`81`	`+ default = 3`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`########################################################################################################################`