-
Notifications
You must be signed in to change notification settings - Fork 17
Added service dropdown picker with null support to the platform_resource widget #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing the regex? The widget allows users to override the picker and enter a custom text, so I think we still want a regex check. Hopefully this is supported. If not, please let us know so we can raise with catalog
@ocofaigh , I was just testing , regex is supported with picker also. |
|
There were two existing resources in the solution: KMS and COS. I added the picker only for COS because KMS supports cross-account functionality, and selecting a resource from a different account is not supported as per this notes
Temp testing tile : https://cloud.ibm.com/catalog/cb453f16-ee96-4bdd-ba3f-b4e0b562c7ec/architecture/deploy-arch-ibm-slz-vpc-a80d7d01-2f12-4f21-9a4f-a37bacea778e |
|
I’ve tested both scenarios:
|
|
/run pipeline |
|
/run pipeline |
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about existing_kms_instance_crn ?
|
Ohh we might need to discuss |
|
@Khuzaima05 Cross account can be supported because these pickers now support overriding the value with your own text. Try it out, it was delivered in the last catalog drop. |
|
@ocofaigh , Could you please approve this PR , I didnot added picker for Key Protect . created issue for supporting for Multiple Services in platform_resource Widget : https://github.ibm.com/ibmcloud/content-catalog/issues/5994 |
|
/run pipeline |
|
TestFullyConfigurableWithFlowLogs, TestRunUpgradeFullyConfigurable tests are failing unrelated to this PR. |
|
/run pipeline |
|
🎉 This PR is included in version 8.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |

Description
Enhanced the platform_resource widget to support service dropdowns picker.
issue: https://github.ibm.com/GoldenEye/issues/issues/16407
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers