Skip to content

Conversation

@Khuzaima05
Copy link
Member

@Khuzaima05 Khuzaima05 commented Nov 11, 2025

Description

Enhanced the platform_resource widget to support service dropdowns picker.

issue: https://github.ibm.com/GoldenEye/issues/issues/16407

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content
  • Added support for service dropdown picker in the platform_resource widget.
  • The dropdown also includes a null option, allowing users to choose null.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing the regex? The widget allows users to override the picker and enter a custom text, so I think we still want a regex check. Hopefully this is supported. If not, please let us know so we can raise with catalog

@Khuzaima05 Khuzaima05 marked this pull request as ready for review November 17, 2025 09:45
@Khuzaima05 Khuzaima05 self-assigned this Nov 17, 2025
@Khuzaima05
Copy link
Member Author

Why are we removing the regex? The widget allows users to override the picker and enter a custom text, so I think we still want a regex check. Hopefully this is supported. If not, please let us know so we can raise with catalog

@ocofaigh , I was just testing , regex is supported with picker also.

@Khuzaima05 Khuzaima05 changed the title added platform_resource widget Added service dropdown picker with null support to the platform_resource widget Nov 17, 2025
@Khuzaima05
Copy link
Member Author

Khuzaima05 commented Nov 17, 2025

There were two existing resources in the solution: KMS and COS. I added the picker only for COS because KMS supports cross-account functionality, and selecting a resource from a different account is not supported as per this notes

Screenshot 2025-11-17 at 3 10 04 PM

Temp testing tile : https://cloud.ibm.com/catalog/cb453f16-ee96-4bdd-ba3f-b4e0b562c7ec/architecture/deploy-arch-ibm-slz-vpc-a80d7d01-2f12-4f21-9a4f-a37bacea778e

@Khuzaima05
Copy link
Member Author

I’ve tested both scenarios:

  • Using an existing COS instance selected from the picker — deployment was successful.
  • Disabling flow logs and setting existing_cos_instance_crn to null — also working as expected.

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about existing_kms_instance_crn ?

@ocofaigh
Copy link
Contributor

Ohh we might need to discuss existing_kms_instance_crn because that input supports both Key Protect and HPCS, but the widget only allows one service.

@Khuzaima05
Copy link
Member Author

What about existing_kms_instance_crn ?

@ocofaigh KMS supports cross-account functionality, and selecting a resource from a different account is not supported as per this notes

@ocofaigh
Copy link
Contributor

ocofaigh commented Nov 18, 2025

@Khuzaima05 Cross account can be supported because these pickers now support overriding the value with your own text. Try it out, it was delivered in the last catalog drop.

@Khuzaima05 Khuzaima05 requested a review from ocofaigh November 19, 2025 14:12
@Khuzaima05
Copy link
Member Author

@ocofaigh , Could you please approve this PR , I didnot added picker for Key Protect . created issue for supporting for Multiple Services in platform_resource Widget : https://github.ibm.com/ibmcloud/content-catalog/issues/5994

@ocofaigh
Copy link
Contributor

/run pipeline

@Khuzaima05
Copy link
Member Author

TestFullyConfigurableWithFlowLogs, TestRunUpgradeFullyConfigurable tests are failing unrelated to this PR.
Re-running

@Khuzaima05
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit 73a8904 into main Nov 20, 2025
2 checks passed
@ocofaigh ocofaigh deleted the test_widget branch November 20, 2025 08:53
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 8.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants