Skip to content

Replace Ruby SDK models with official Smithy repository #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

bendrucker
Copy link
Member

@bendrucker bendrucker commented Jun 25, 2025

Replace the API models from AWS SDK Ruby with the new/official https://github.com/aws/api-models-aws repository. This uses a slightly different format, which is now publicly documented:

https://smithy.io/2.0/spec/index.html

Diffs

  • The old models represented enum as an array, whereas Smithy's enums are unordered in their JSON representation (object). So there is some necessary but meaningless changes to the ordering of slices. At best we can sort for stability.
  • New enum values added from AWS API updates: ACCOUNT_INTERNAL_ACCESS and ORGANIZATION_INTERNAL_ACCESS for Access Analyzer types

Related

Closes #893
Closes #900

bendrucker and others added 11 commits June 25, 2025 09:48
- Enhanced pattern transformation logic to minimize unnecessary diffs
- Fixed broken ^(?s) patterns in Amplify validation rules
- Removed placeholder text being treated as literal regex patterns
- Preserved original format for character class and role ARN patterns
- Reduced spurious pattern changes from 78 to 7 files (90% reduction)
- All remaining changes are legitimate backward compatibility transformations

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
…lity

- Remove spurious $ anchors from simple patterns like ^[a-z0-9]{4,7}$
- Preserve $ anchors for complex patterns like certificate validation
- Fixed aws_signer_signing_job_invalid_profile_name.go spurious diff
- Refined pattern logic to only affect simple quantified character classes
- Maintains validation behavior while minimizing unnecessary diffs

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Use Smithy models from official repository
1 participant