deprecated_interpolation: Prevent autofix from producing ambiguous attribute keys #189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #185
The current autofix for the
terraform_deprecated_interpolation
rule does not recognize expression context and will always fix"${var.foo}"
tovar.foo
. However, if an object key is a deprecated interpolation, it must be wrapped in parentheses to prevent ambiguous attribute key errors.This PR takes inspiration from hashicorp/terraform#26949 and fixes it so that autofixed code are wrapped in parentheses when the object key is a deprecated interpolation.
Before
After