go: remove loop variable copying (#2044)

bendrucker · web-flow · commit 6adba23df452 · 2024-05-06T18:33:20.000-07:00
diff --git a/.golangci.yml b/.golangci.yml
@@ -4,6 +4,7 @@ linters:
   enable:
     - gci
     - gofmt
+    - copyloopvar
 issues:
   exclude-dirs:
     - terraform/
diff --git a/plugin/install_test.go b/plugin/install_test.go
@@ -70,8 +70,6 @@ func TestNewGitHubClient(t *testing.T) {
 	}
 
 	for _, tc := range cases {
-		tc := tc
-
 		t.Run(tc.name, func(t *testing.T) {
 			client, err := newGitHubClient(context.Background(), tc.config)
 			if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -70,8 +70,6 @@ func TestNewGitHubClient(t *testing.T) {`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`for _, tc := range cases {`
`73`		`- tc := tc`
`74`		`-`
`75`	`73`	`t.Run(tc.name, func(t *testing.T) {`
`76`	`74`	`client, err := newGitHubClient(context.Background(), tc.config)`
`77`	`75`	`if err != nil {`