terraform_required_providers: emit error when only source is specified

Author: bendrucker

rules/terraformrules/terraform_required_providers.go

@@ -80,7 +80,7 @@ func (r *TerraformRequiredProvidersRule) Check(runner *tflint.Runner) error {
 			continue
 		}
 
-		if _, ok := module.ProviderRequirements.RequiredProviders[name]; !ok {
+		if provider, ok := module.ProviderRequirements.RequiredProviders[name]; !ok || provider.Requirement.Required == nil {
 			runner.EmitIssue(r, fmt.Sprintf(`Missing version constraint for provider "%s" in "required_providers"`, name), decl)
 		}
 	}

rules/terraformrules/terraform_required_providers_test.go

@@ -87,18 +87,65 @@ data "template_file" "foo" {
 			},
 		},
 		{
-			Name: "required_providers set",
+			Name: "required_providers object",
 			Content: `
 terraform {
 	required_providers {
-		template = "~> 2"
+		template = {
+			source  = "hashicorp/template"
+			version = "~> 2" 
+		}
 	}
 }
 
 provider "template" {} 
 `,
 			Expected: tflint.Issues{},
 		},
+		{
+			Name: "required_providers string",
+			Content: `
+terraform {
+	required_providers {
+		template = "~> 2" 
+	}
+}
+
+provider "template" {} 
+`,
+			Expected: tflint.Issues{},
+		},
+		{
+			Name: "required_providers object missing version",
+			Content: `
+terraform {
+	required_providers {
+		template = {
+			source = "hashicorp/template"
+		}
+	}
+}
+
+provider "template" {} 
+`,
+			Expected: tflint.Issues{
+				{
+					Rule:    NewTerraformRequiredProvidersRule(),
+					Message: `Missing version constraint for provider "template" in "required_providers"`,
+					Range: hcl.Range{
+						Filename: "module.tf",
+						Start: hcl.Pos{
+							Line:   10,
+							Column: 1,
+						},
+						End: hcl.Pos{
+							Line:   10,
+							Column: 20,
+						},
+					},
+				},
+			},
+		},
 		{
 			Name: "single provider with alias",
 			Content: `
@@ -125,11 +172,14 @@ provider "template" {
 			},
 		},
 		{
-			Name: "version set with alias",
+			Name: "version set",
 			Content: `
 terraform {
   required_providers {
-    template = "~> 2"
+    template = {
+			source = "hashicorp/template"
+			version = "~> 2"
+		}
   }
 }
 
@@ -144,23 +194,26 @@ provider "template" {
 					Range: hcl.Range{
 						Filename: "module.tf",
 						Start: hcl.Pos{
-							Line:   8,
+							Line:   11,
 							Column: 1,
 						},
 						End: hcl.Pos{
-							Line:   8,
+							Line:   11,
 							Column: 20,
 						},
 					},
 				},
 			},
 		},
 		{
-			Name: "version set",
+			Name: "version set with alias",
 			Content: `
 terraform {
   required_providers {
-    template = "~> 2"
+    template = {
+			source = "hashicorp/template"
+			version = "~> 2"
+		}
   }
 }
 
@@ -176,11 +229,11 @@ provider "template" {
 					Range: hcl.Range{
 						Filename: "module.tf",
 						Start: hcl.Pos{
-							Line:   8,
+							Line:   11,
 							Column: 1,
 						},
 						End: hcl.Pos{
-							Line:   8,
+							Line:   11,
 							Column: 20,
 						},
 					},