Skip to content

Commit c40ee70

Browse files
authored
terraformrules: Get module contents with IncludeNotCreated: true (#1458)
1 parent 36628eb commit c40ee70

13 files changed

+32
-13
lines changed

rules/terraformrules/terraform_documented_outputs.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ func (r *TerraformDocumentedOutputsRule) Check(runner *tflint.Runner) error {
5757
},
5858
},
5959
},
60-
}, sdk.GetModuleContentOption{})
60+
}, sdk.GetModuleContentOption{IncludeNotCreated: true})
6161
if diags.HasErrors() {
6262
return diags
6363
}

rules/terraformrules/terraform_documented_variables.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ func (r *TerraformDocumentedVariablesRule) Check(runner *tflint.Runner) error {
5757
},
5858
},
5959
},
60-
}, sdk.GetModuleContentOption{})
60+
}, sdk.GetModuleContentOption{IncludeNotCreated: true})
6161
if diags.HasErrors() {
6262
return diags
6363
}

rules/terraformrules/terraform_module_pinned_source.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ func (r *TerraformModulePinnedSourceRule) Check(runner *tflint.Runner) error {
6666
return err
6767
}
6868

69-
body, diags := runner.GetModuleContent(moduleCallSchema, sdk.GetModuleContentOption{})
69+
body, diags := runner.GetModuleContent(moduleCallSchema, sdk.GetModuleContentOption{IncludeNotCreated: true})
7070
if diags.HasErrors() {
7171
return diags
7272
}

rules/terraformrules/terraform_module_version.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ func (r *TerraformModuleVersionRule) Check(runner *tflint.Runner) error {
6262
return err
6363
}
6464

65-
body, diags := runner.GetModuleContent(moduleCallSchema, sdk.GetModuleContentOption{})
65+
body, diags := runner.GetModuleContent(moduleCallSchema, sdk.GetModuleContentOption{IncludeNotCreated: true})
6666
if diags.HasErrors() {
6767
return diags
6868
}

rules/terraformrules/terraform_naming_convention.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ func (r *TerraformNamingConventionRule) Check(runner *tflint.Runner) error {
123123
Body: &hclext.BodySchema{},
124124
},
125125
},
126-
}, sdk.GetModuleContentOption{})
126+
}, sdk.GetModuleContentOption{IncludeNotCreated: true})
127127
if diags.HasErrors() {
128128
return diags
129129
}

rules/terraformrules/terraform_required_providers.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ func (r *TerraformRequiredProvidersRule) Check(runner *tflint.Runner) error {
6161
},
6262
},
6363
},
64-
}, sdk.GetModuleContentOption{})
64+
}, sdk.GetModuleContentOption{IncludeNotCreated: true})
6565
if diags.HasErrors() {
6666
return diags
6767
}
@@ -102,7 +102,7 @@ func (r *TerraformRequiredProvidersRule) Check(runner *tflint.Runner) error {
102102
},
103103
},
104104
},
105-
}, sdk.GetModuleContentOption{})
105+
}, sdk.GetModuleContentOption{IncludeNotCreated: true})
106106
if diags.HasErrors() {
107107
return diags
108108
}

rules/terraformrules/terraform_required_version.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func (r *TerraformRequiredVersionRule) Check(runner *tflint.Runner) error {
5555
},
5656
},
5757
},
58-
}, sdk.GetModuleContentOption{})
58+
}, sdk.GetModuleContentOption{IncludeNotCreated: true})
5959
if diags.HasErrors() {
6060
return diags
6161
}

rules/terraformrules/terraform_standard_module_structure.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ func (r *TerraformStandardModuleStructureRule) Check(runner *tflint.Runner) erro
6767
Body: &hclext.BodySchema{},
6868
},
6969
},
70-
}, sdk.GetModuleContentOption{})
70+
}, sdk.GetModuleContentOption{IncludeNotCreated: true})
7171
if diags.HasErrors() {
7272
return diags
7373
}

rules/terraformrules/terraform_typed_variables.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ func (r *TerraformTypedVariablesRule) Check(runner *tflint.Runner) error {
5656
},
5757
},
5858
},
59-
}, sdk.GetModuleContentOption{})
59+
}, sdk.GetModuleContentOption{IncludeNotCreated: true})
6060
if diags.HasErrors() {
6161
return diags
6262
}

rules/terraformrules/terraform_unused_declaration.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ func (r *TerraformUnusedDeclarationsRule) declarations(runner *tflint.Runner) (*
109109
Body: &hclext.BodySchema{},
110110
},
111111
},
112-
}, sdk.GetModuleContentOption{})
112+
}, sdk.GetModuleContentOption{IncludeNotCreated: true})
113113
if diags.HasErrors() {
114114
return decl, diags
115115
}

rules/terraformrules/terraform_unused_required_providers_test.go

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,25 @@ func Test_TerraformUnusedRequiredProvidersRule(t *testing.T) {
239239
},
240240
},
241241
},
242+
{
243+
Name: "used - unevaluated resource",
244+
Content: `
245+
terraform {
246+
required_providers {
247+
null = {
248+
source = "hashicorp/null"
249+
}
250+
}
251+
}
252+
253+
variable "foo" {}
254+
255+
resource "null_resource" "foo" {
256+
count = var.foo
257+
}
258+
`,
259+
Expected: tflint.Issues{},
260+
},
242261
}
243262

244263
rule := NewTerraformUnusedRequiredProvidersRule()

rules/terraformrules/terraform_workspace_remote.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ func (r *TerraformWorkspaceRemoteRule) Check(runner *tflint.Runner) error {
6464
},
6565
},
6666
},
67-
}, sdk.GetModuleContentOption{})
67+
}, sdk.GetModuleContentOption{IncludeNotCreated: true})
6868
if diags.HasErrors() {
6969
return diags
7070
}

rules/terraformrules/utils.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ func getProviderRefs(runner *tflint.Runner) (map[string]*providerRef, hcl.Diagno
155155
},
156156
},
157157
},
158-
}, sdk.GetModuleContentOption{})
158+
}, sdk.GetModuleContentOption{IncludeNotCreated: true})
159159
if diags.HasErrors() {
160160
return providerRefs, diags
161161
}

0 commit comments

Comments
 (0)