Remove deprecated camel-case and param-case dependencies #186
+13
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kytta
suggested changes
Mar 11, 2025
kytta
left a comment
kytta
left a comment
There was a problem hiding this comment.
Hey there; keep in mind that I am not the maintainer of this project, but I saw your PR and decided to add my two cents of opinion :)
cli.js
Outdated
| import { paramCase } from 'param-case'; | ||
| import { Command } from 'commander'; | ||
| import { minify } from './src/htmlminifier.js'; | ||
| import * as changeCase from 'change-case'; |
There was a problem hiding this comment.
suggestion: Use named exports
This way we could profit from tree-shaking and introduce less diffs to this PR.
Suggested change
| import * as changeCase from 'change-case'; | |
| import { camelCase, kebabCase } from 'change-case'; |
Don't forget to upgrade other usages :)
kytta
approved these changes
Mar 11, 2025
…-case-change-pkgs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated dependencies and replace with well-maintained one.