chore: Update pyproject and tests to support Mac's/arm local development #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which seems to work with ibm specifically
terry-docker
force-pushed
the
support-arm-local-development
branch
from
b1cf47a to
7c4d4c8
Compare
ambitda
previously approved these changes
May 7, 2025
alexanderankin
approved these changes
May 7, 2025
terry-docker
changed the title
terry-docker
force-pushed
the
support-arm-local-development
branch
from
f555efe to
7522fbf
Compare
terry-docker
force-pushed
the
support-arm-local-development
branch
from
7522fbf to
28d7024
Compare
terry-docker
force-pushed
the
support-arm-local-development
branch
from
1f2c17b to
8cdd6c8
Compare
terry-docker
commented
May 12, 2025
.github/workflows/ci-core.yml
Outdated
Comment on lines
28
to
35
| - name: Display Docker and Compose Versions | ||
| run: | | ||
| @echo "##[group]Docker Version" | ||
| @docker --version || echo "Docker is not installed or misconfigured" | ||
| @echo "##[endgroup]" | ||
| @echo "##[group]Docker Compose Version" | ||
| @docker compose version || docker-compose --version || echo "Docker Compose is not installed or misconfigured" | ||
| @echo "##[endgroup]" |
There was a problem hiding this comment.
Added this to workflow command to help with debugging docker errors in the checks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #814 +/- ##
=======================================
Coverage ? 85.46%
=======================================
Files ? 12
Lines ? 688
Branches ? 110
=======================================
Hits ? 588
Misses ? 75
Partials ? 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to help contribute to testcontainers-python but issues getting the local environment running. Starting off with fixing the install + test suite so myself and other people on Mac can get up and running faster.
Manual testing done:
This branch was tested on a few different Mac machines the and a Linux VM (still on arm).
make installandmake testschecked in all envs, I also checked docs, build, and cleans on the Linux VM and a M2 mac.Notes:
Ticket:
#813