Skip to content

feat: expand async matcher support #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 14, 2025

Conversation

puglyfe
Copy link
Contributor

@puglyfe puglyfe commented Jul 10, 2025

Checks

Changes

This expands support for additional async matchers (specifically, jasmine) to reduce false positives for await-async-queries and await-async-utils. As mentioned in the linked issue, I understand any hesitancy to include framework-specific logic, but I think this is a relatively trivial addition to open up support to another testing framework.

Context

Fixes #1039

@Belco90 Belco90 self-requested a review July 10, 2025 21:03
@Belco90 Belco90 added the enhancement New feature or request label Jul 10, 2025
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (b1a4da7) to head (db05d13).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1040      +/-   ##
==========================================
+ Coverage   96.30%   96.49%   +0.18%     
==========================================
  Files          47       49       +2     
  Lines        2542     2679     +137     
  Branches     1047     1106      +59     
==========================================
+ Hits         2448     2585     +137     
  Misses         94       94              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I added some comments, but the implementation seems fine in general.

@puglyfe puglyfe requested a review from Belco90 July 11, 2025 15:29
@Belco90 Belco90 merged commit c27465e into testing-library:main Jul 14, 2025
31 checks passed
@Belco90
Copy link
Member

Belco90 commented Jul 14, 2025

@all-contributors please add @puglyfe for code and test

Copy link
Contributor

@Belco90

I've put up a pull request to add @puglyfe! 🎉

Copy link

🎉 This PR is included in version 7.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support additional async matchers when detecting handled promises
2 participants