Skip to content

fix(no-node-access): Avoid false positives when Testing Library is not imported #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

y-hsgw
Copy link
Member

@y-hsgw y-hsgw commented Jul 12, 2025

Checks

Changes

  • Avoid false positives by reporting only when Testing Library or custom utils module is imported.

Context

These comments should be resolved with this.

Copy link

codecov bot commented Jul 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (7812dae) to head (74a17fa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1042   +/-   ##
=======================================
  Coverage   96.48%   96.49%           
=======================================
  Files          49       49           
  Lines        2678     2681    +3     
  Branches     1110     1112    +2     
=======================================
+ Hits         2584     2587    +3     
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Belco90
Copy link
Member

Belco90 commented Jul 14, 2025

I don't think this is necessary, the plugin should be run only against test files.

@Belco90 Belco90 closed this Jul 14, 2025
@y-hsgw y-hsgw deleted the fix/no-node-access branch July 14, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants