Skip to content

fix(no-node-access): support user-event instances returned from custom render #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

y-hsgw
Copy link
Member

@y-hsgw y-hsgw commented Jul 18, 2025

Checks

Changes

  • Improved detection of user-event calls from render-returned objects in custom testing utilities.

Context

Fixes: Comments below
#1033 (review)

Copy link

codecov bot commented Jul 18, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.46%. Comparing base (35e2b40) to head (7de4ee1).

Files with missing lines Patch % Lines
lib/rules/no-node-access.ts 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
- Coverage   96.48%   96.46%   -0.03%     
==========================================
  Files          49       49              
  Lines        2678     2686       +8     
  Branches     1107     1112       +5     
==========================================
+ Hits         2584     2591       +7     
- Misses         94       95       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant