From c07f1a3273b39aaacbbbd9ce5ca9b557f42855ac Mon Sep 17 00:00:00 2001 From: Soliheen Farooq Khan Date: Sun, 18 Aug 2024 14:41:37 +0530 Subject: [PATCH 1/2] madeLabelOptionalInDropdownComponent --- packages/ui/src/components/Dropdown/Dropdown.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ui/src/components/Dropdown/Dropdown.tsx b/packages/ui/src/components/Dropdown/Dropdown.tsx index 58d476864..d46b50587 100644 --- a/packages/ui/src/components/Dropdown/Dropdown.tsx +++ b/packages/ui/src/components/Dropdown/Dropdown.tsx @@ -45,7 +45,7 @@ export interface DropdownProps extends Pick; enableTypeAhead?: boolean; renderTrigger?: (theme: FlowbiteDropdownTheme) => ReactElement; From 8b19b3495a6235f19d089bf9c4452af6934259b8 Mon Sep 17 00:00:00 2001 From: Soliheen Farooq Khan Date: Sun, 25 Aug 2024 18:53:36 +0530 Subject: [PATCH 2/2] addedMouseEventInDropdownItemComponent --- packages/ui/src/components/Dropdown/DropdownItem.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/ui/src/components/Dropdown/DropdownItem.tsx b/packages/ui/src/components/Dropdown/DropdownItem.tsx index e4806ad9c..e463a7c01 100644 --- a/packages/ui/src/components/Dropdown/DropdownItem.tsx +++ b/packages/ui/src/components/Dropdown/DropdownItem.tsx @@ -1,7 +1,7 @@ "use client"; import { useListItem, useMergeRefs } from "@floating-ui/react"; -import { forwardRef, type ComponentProps, type ElementType, type FC, type RefCallback } from "react"; +import { forwardRef, type ComponentProps, type ElementType, type FC, type RefCallback, MouseEvent } from "react"; import { twMerge } from "tailwind-merge"; import type { PolymorphicComponentPropWithRef, PolymorphicRef } from "../../helpers/generic-as-prop"; import { mergeDeep } from "../../helpers/merge-deep"; @@ -20,7 +20,7 @@ export type DropdownItemProps = PolymorphicCom { href?: string; icon?: FC>; - onClick?: () => void; + onClick?: (event: MouseEvent) => void; theme?: DeepPartial; } >; @@ -49,8 +49,8 @@ export const DropdownItem = forwardRef( className={twMerge(theme.base, className)} {...theirProps} {...getItemProps({ - onClick: () => { - onClick?.(); + onClick: (event) => { + onClick?.(event); dismissOnClick && handleSelect(null); }, })}