List of random issues

[Sqrcz]

Hey 👋

While refactoring this library to introduce component prefix and better linting I wen't through every single file... and since I was updating components as well as docs I have few thoughts about implementation, styling, usage of props, errors and the other more or less opinionated things...

Here is the "raw" list of issues I found during the above process... some would require separate tickets/discussions... some just decision which way to go with them.

When responding please use "Issue number" and if we'll create dedicated tickets... I'll edit this message to link them properly.

1. paragraph should have mb3 as default with mb-0 for the last one - Feature/paragraph updates #257
2. heading should be H element - feat(new component): Initial typography #199
3. link should be <router-link> if prop to is set
4. images shouldn't be linked from other repos like flowbite-svelte
5. no need for props for things that can be achieved by tailwind class (align, size)
6. review and remove /* eslint-disable... - maintenance - unnecessary eslint-disable removed #376
7. avatar status is not visible when image is used - Feature/avatar updates #258
8. avatar-stack-counter shouldn't be a link - it is link in Figma - Avatar - Stacked
9. type check for avatar-stack-counter total doesn't work
10. breadcrumb-item should be used internally and breadcrumbs component should accept array
11. breadcrumb-item should be <router-link> if prop to is set
12. <Accordion :open-first-item="false"> should be just <Accordion first-item-closed> - Feature: improved Accordion component flexibility #351
13. button loading state should replace content without affecting button size - this is aligned with Flowbite - Button - Loader (worth escalating)
14. carousel component needs refactoring, slide animation is not working, should have prop for auto-start and interval instead of slide and slide-interval, animation prop is not used
15. dropdown placements right and left are working on second click (bad position on first one)
16. should dropdown arrow be aligned with dropdown placement?
17. fwb-list-group-item hover only makes sense if it's clickable (should accept href or to)
18. pagination could use button-group internally
19. disabled pagination button should not have hover effect ("Previous" / "Next") - refactor: Update disabledClasses in FwbPagination.vue #319
20. besideText slot in fwb-rating component should have default styling
21. rating component should be able to manage floats
22. it should be possible to have rating count without a link (it's called review-text)
23. spinner size should not be based on fixed classes but something like: w-${size} h-${size}
24. tabs directive should be boolean and named like directive-show (easier DX)
25. click:pane should pass through event data
26. Toast component type="empty" shouldn't be needed (without-icon would make more sense and allow for more flexibility)
27. example for Interactive Toast doesn't work without flowbite-themable component
28. Toasts are lacking one of the main functionality (dynamic dysplaying in predefined positions)
29. "hovered" Tooltip dissapears on click
30. file-input should have accept prop to allow for file extensions filtering - feat: Label added for FileInput dropzone #304
31. file-input with deopzone="true" doesn't accept multiple files
32. checkbox label could have class select-none so it's text is not selectable on multiple clicks
33. checkbox and radio lists should be created by dedicated components - Refactor FwbCheckbox – Improved Styling & Group Support #368
34. in range component label's for attribute can't be hard-coded
35. table component should not require building table manually... (https://bootstrap-vue.org/docs/components/table is a good example)
36. Alert's additional-content example could use fwb-button instead of HTML one
37. we should unify sizes... sometime we have prop size with different options and sometimes we have dedicated prop like large (pagination)
38. Failed to resolve component: router-link in Sidebar component (we need to add vue router dependency for that to work)
39. file upload component button is too dark in light theme

[cogor]

2. Done (Components renaming #225)

[Sqrcz]

1. redy for review in Feature/paragraph updates #257

[Sqrcz]

7. ready for review in Feature/avatar updates #258

[Sqrcz]

20. Fixed in refactor: Update disabledClasses in FwbPagination.vue #319

[wazeerc]

@Sqrcz Is this list of issues up-to-date?

[Sqrcz]

Hey @wazeerc 👋

Few components were completely refactored... I'll go over this list this week and update it... thanks for the reminder ;)

[Sqrcz]

Hey, I've updated the list above... If you have time or want to... be happy to pick something ;)

[wazeerc]

36. Done - Refactor alert examples to use FwbButton #377

[wazeerc]

32. Done - Improve text selection handling in FwbCheckbox label #378

[wazeerc]

31. Done - Improve file handling and layout for file inputs #379

[Sqrcz]

Thank you!

We have a long weekend in Poland now... I'll be able to take a look a those next week.