"Final"ize all the things #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of them (except one) simply implemented an interface and had no other methods, so there's really no point in making them extendable. The one exception was `CloseBracketParser` which had a few `protected` methods which really should have been `private`, so we made that change.
|
Is this a firm policy? I'm trying to extend the SmartPunct classes for LaTeX output but can't. Would you be willing to look at a change to those classes to remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically anything that is now completed covered by one or more interfaces (no other
publicorprotectedmethods) has been markedfinal. See https://ocramius.github.io/blog/when-to-declare-classes-final/ for some rationale behind this.