Skip to content

fix: Fix the configuration of the extension when DBAL is not configured #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

theofidry
Copy link
Contributor

Currently if you happen to not configure DoctrineDBAL, the extension will append the types to the DBAL configuration resulting in an invalid config, which will crash the booting of the Symfony app.

A typical scenario where DBAL may not be configured is if you an an environment with in-memory tests, where DBAL is not used at all.

@theofidry
Copy link
Contributor Author

The CS of the other files is addressed in #141.

@theofidry
Copy link
Contributor Author

the CI failure looks unrelated

@theofidry
Copy link
Contributor Author

@chalasr rebased

@chalasr
Copy link
Member

chalasr commented Dec 31, 2023

This seems to break tests

@theofidry
Copy link
Contributor Author

@chalasr green!

@chalasr
Copy link
Member

chalasr commented Apr 17, 2025

Thank you @theofidry.

@chalasr chalasr merged commit fd6b27c into thephpleague:master Apr 17, 2025
23 checks passed
@theofidry theofidry deleted the fix/no-db branch April 19, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants