New directory structure #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing test looks a transient error |
|
👍 Thanks. Can you please open the recipe PR? |
chalasr
force-pushed
the
new-directory-structure
branch
from
8073beb to
c815d17
Compare
|
Thank you Antonio. |
I will open it as soon as possible. I assume you will tag a v0.11 version before v1.0. |
|
Not necessarily, I think the next version will be 1.0 no matter what's inside :) I mean it's not an issue if 1.1 comes quickly. |
|
But this PR introduces two deprecations. If we are going to publish them in v1.0, I thought we should wait until v2.0 to remove them. Another option would be to remove the deprecations and add an UPGRADE.md file for v1.0. |
|
Good point, I'll release 1.0 right after 0.11 (same minus BC layers) |
|
Recipe PR: symfony/recipes-contrib#1770 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can adopt the recommended bundle directory structure before tagging v1.0.
All we have to do is move the
./src/Resources/configdirectory to./config.I see only one caveat to this: route loading. So I've included two files that will trigger a deprecation if you load them:
./Resources/config/routes.phpwill trigger a deprecation if you load the routes using the@LeagueOAuth2ServerBundle/Resources/config/routes.phpnotation recommended in the installation doc../src/Resources/config/routes.phpwill trigger a deprecation if you load the routes with a reference to the old file location in the file system.We will need to update the Flex recipe when this PR is merged.