Skip to content

Conversation

brianheineman
Copy link
Contributor

@brianheineman brianheineman commented Feb 5, 2025

Addresses #71

Copy link
Contributor

github-actions bot commented Feb 5, 2025

🐰 Bencher Report

Branchadd-magic-benchmark
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
file-format::from_bytes📈 view plot
⚠️ NO THRESHOLD
1,638.70
file-format::from_bytes (2GiB)📈 view plot
⚠️ NO THRESHOLD
1,592.40
file_type::from_bytes📈 view plot
⚠️ NO THRESHOLD
1,178.30
file_type::from_bytes (2GiB)📈 view plot
⚠️ NO THRESHOLD
1,191.30
file_type::from_extension📈 view plot
⚠️ NO THRESHOLD
20.00
file_type::from_id📈 view plot
⚠️ NO THRESHOLD
20.88
file_type::from_media_type📈 view plot
⚠️ NO THRESHOLD
23.07
file_type::try_from_file📈 view plot
⚠️ NO THRESHOLD
10,822.00
infer::from_bytes📈 view plot
⚠️ NO THRESHOLD
319.55
infer::from_bytes (2GiB)📈 view plot
⚠️ NO THRESHOLD
373.88
magic::from_bytes📈 view plot
⚠️ NO THRESHOLD
728,240.00
mime_guess::from_extension📈 view plot
⚠️ NO THRESHOLD
9.03
mime_guess::from_media_type📈 view plot
⚠️ NO THRESHOLD
104.74
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.14%. Comparing base (43e70a6) to head (cde37b2).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files          22       22           
  Lines        3009     3009           
=======================================
  Hits         2923     2923           
  Misses         86       86           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robo9k
Copy link

robo9k commented Feb 5, 2025

Apologies for the trouble running this on macOS, there are some open issues about this for the underlying magic-sys crate that a new unpublished version should fix, but the magic crate will also need to be updated for this.

Running on Linux should work out of the box and is what I can support best.

@brianheineman
Copy link
Contributor Author

@robo9k no worries, since the benchmarks are largely used for trending and comparison I can switch them to run on linux.

@brianheineman brianheineman merged commit f080e80 into main Feb 6, 2025
17 checks passed
@brianheineman brianheineman deleted the add-magic-benchmark branch February 6, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants