Serial.print() have to be: comms->print()#37
Closed
sigmaeo wants to merge 9 commits into
Closed
Conversation
|
@sigmaeo I will accept PR on gyssels/Arduino-CmdMessenger, and I messaging the other PR submitters so it can become an active branch |
Two small changes because of grumbling from the compiler Arduino 1.8.19.
A small change because of grumbling from the compiler Arduino 1.8.19.
thijse
added a commit
that referenced
this pull request
Jun 1, 2026
Applied PRs: - #33: Fix Adafruit library name in library.json - #35: Add #if guards for CMDMESSENGER_MAXCALLBACKS, LastArgLength tracking - #36: Fix startCommand init, Serial.print->comms->print, return NULL fix - #37: Add unescape() calls in readStringArg/copyStringArg/compareStringArg - #42: Fix min/max types for ESP8266 (ConsoleShell, HeaterSim) - #44: Reformat LICENSE.md for GitHub detection New features (from MobiFlight fork): - sendArg(T) - send argument without field separator - sendArg(T, n) - send with precision, no separator - sendSciArg(double, n) - scientific notation, no separator - sendBinArg(T) - binary format, no separator - New example: SendWithoutSeparator Other: - Add VS Code tasks.json and launch.json - Add .gitignore - Add new keywords to keywords.txt
Owner
|
Thank you — all of the substantive fixes in this PR are already present in the current codebase: comms->print() is used throughout, unescape() is called in all string read functions, split_r() tracks LastArgLength, and readBin() has bounds checking. Closing as already applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.) fixed: 3x Serial left instead of 3x comms
2.) make readBin() safe for less received bytes (see issue #38)
3.) fixed some missing unescape() (see issue #39)