fix(lint): linter issue with redifinition of max (#2669)

thomaspoignant · web-flow · commit 4e4b60dc5f52 · 2024-11-11T10:52:17.000+01:00
diff --git a/internal/utils/hash.go b/internal/utils/hash.go
@@ -14,10 +14,10 @@ func Hash(s string) uint32 {
 }
 
 // BuildHash is building the hash based on the different properties of the evaluation.
-func BuildHash(flagName string, bucketingKey string, max uint32) uint32 {
-	// this is not supposed to happen, but to avoid a crash if max is 0 we are returning 0
-	if max == uint32(0) {
+func BuildHash(flagName string, bucketingKey string, maxPercentage uint32) uint32 {
+	// this is not supposed to happen, but to avoid a crash if maxPercentage is 0 we are returning 0
+	if maxPercentage == uint32(0) {
 		return uint32(0)
 	}
-	return Hash(flagName+bucketingKey) % max
+	return Hash(flagName+bucketingKey) % maxPercentage
 }

Original file line number	Diff line number	Diff line change
`@@ -14,10 +14,10 @@ func Hash(s string) uint32 {`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`// BuildHash is building the hash based on the different properties of the evaluation.`
`17`		`-func BuildHash(flagName string, bucketingKey string, max uint32) uint32 {`
`18`		`- // this is not supposed to happen, but to avoid a crash if max is 0 we are returning 0`
`19`		`- if max == uint32(0) {`
	`17`	`+func BuildHash(flagName string, bucketingKey string, maxPercentage uint32) uint32 {`
	`18`	`+ // this is not supposed to happen, but to avoid a crash if maxPercentage is 0 we are returning 0`
	`19`	`+ if maxPercentage == uint32(0) {`
`20`	`20`	`return uint32(0)`
`21`	`21`	`}`
`22`		`- return Hash(flagName+bucketingKey) % max`
	`22`	`+ return Hash(flagName+bucketingKey) % maxPercentage`
`23`	`23`	`}`