Skip to content

Commit 870c7f8

Browse files
committed
chore: fix lints
1 parent 9f732ca commit 870c7f8

File tree

3 files changed

+15
-14
lines changed

3 files changed

+15
-14
lines changed

exporter/data_exporter.go

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,24 +17,24 @@ const (
1717
)
1818

1919
// ExporterConfig holds the configuration for an individual exporter
20-
type ExporterConfig struct {
20+
type Config struct {
2121
Exporter CommonExporter
2222
FlushInterval time.Duration
2323
MaxEventInMemory int64
2424
}
2525

2626
// ExporterState maintains the state for a single exporter
27-
type ExporterState struct {
28-
config ExporterConfig
27+
type State struct {
28+
config Config
2929
ticker *time.Ticker
3030
lastIndex int // Index of the last processed event
3131
}
3232

3333
// Scheduler handles data collection for one or more exporters
3434
type Scheduler struct {
3535
sharedCache []FeatureEvent
36-
bulkExporters map[CommonExporter]*ExporterState // Only bulk exporters that need periodic flushing
37-
directExporters []CommonExporter // Non-bulk exporters that flush immediately
36+
bulkExporters map[CommonExporter]*State // Only bulk exporters that need periodic flushing
37+
directExporters []CommonExporter // Non-bulk exporters that flush immediately
3838
mutex sync.Mutex
3939
daemonChan chan struct{}
4040
logger *fflog.FFLogger
@@ -46,22 +46,22 @@ func NewScheduler(ctx context.Context, flushInterval time.Duration, maxEventInMe
4646
exp CommonExporter, logger *fflog.FFLogger,
4747
) *Scheduler {
4848
// Convert single exporter parameters to ExporterConfig
49-
config := ExporterConfig{
49+
config := Config{
5050
Exporter: exp,
5151
FlushInterval: flushInterval,
5252
MaxEventInMemory: maxEventInMemory,
5353
}
54-
return NewMultiScheduler(ctx, []ExporterConfig{config}, logger)
54+
return NewMultiScheduler(ctx, []Config{config}, logger)
5555
}
5656

5757
// NewMultiScheduler creates a scheduler that handles multiple exporters
58-
func NewMultiScheduler(ctx context.Context, exporterConfigs []ExporterConfig, logger *fflog.FFLogger,
58+
func NewMultiScheduler(ctx context.Context, exporterConfigs []Config, logger *fflog.FFLogger,
5959
) *Scheduler {
6060
if ctx == nil {
6161
ctx = context.Background()
6262
}
6363

64-
bulkExporters := make(map[CommonExporter]*ExporterState)
64+
bulkExporters := make(map[CommonExporter]*State)
6565
directExporters := make([]CommonExporter, 0)
6666

6767
for _, config := range exporterConfigs {
@@ -73,7 +73,7 @@ func NewMultiScheduler(ctx context.Context, exporterConfigs []ExporterConfig, lo
7373
}
7474

7575
if config.Exporter.IsBulk() {
76-
state := &ExporterState{
76+
state := &State{
7777
config: config,
7878
lastIndex: -1,
7979
ticker: time.NewTicker(config.FlushInterval),
@@ -130,15 +130,15 @@ func (s *Scheduler) AddEvent(event FeatureEvent) {
130130
}
131131

132132
// getPendingEvents returns events that haven't been processed by this exporter
133-
func (s *Scheduler) getPendingEvents(state *ExporterState) []FeatureEvent {
133+
func (s *Scheduler) getPendingEvents(state *State) []FeatureEvent {
134134
if state.lastIndex+1 >= len(s.sharedCache) {
135135
return nil
136136
}
137137
return s.sharedCache[state.lastIndex+1:]
138138
}
139139

140140
// flushExporter sends pending events to the specified exporter
141-
func (s *Scheduler) flushExporter(state *ExporterState) {
141+
func (s *Scheduler) flushExporter(state *State) {
142142
pendingEvents := s.getPendingEvents(state)
143143
if len(pendingEvents) == 0 {
144144
return

feature_flag.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,9 @@ func New(config Config) (*GoFeatureFlag, error) {
138138
)
139139
} else {
140140
// Multiple exporters case
141-
exporterConfigs := make([]exporter.ExporterConfig, len(dataExporters))
141+
exporterConfigs := make([]exporter.Config, len(dataExporters))
142142
for i, de := range dataExporters {
143-
exporterConfigs[i] = exporter.ExporterConfig{
143+
exporterConfigs[i] = exporter.Config{
144144
Exporter: de.Exporter,
145145
FlushInterval: de.FlushInterval,
146146
MaxEventInMemory: de.MaxEventInMemory,

testutils/mock/exporter_mock.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ func (m *Exporter) Export(ctx context.Context, _ *fflog.FFLogger, events []expor
2626
m.ExportedEvents = append(m.ExportedEvents, events...)
2727
if m.Err != nil {
2828
if m.ExpectedNumberErr > m.CurrentNumberErr {
29+
m.ExportedEvents = m.ExportedEvents[:len(m.ExportedEvents)-len(events)]
2930
m.CurrentNumberErr++
3031
return m.Err
3132
}

0 commit comments

Comments
 (0)