fix: improve error handling in test registration by catching exceptions during event receiver invocation

Author: thomhurst

TUnit.Engine/Building/TestBuilder.cs

@@ -698,7 +698,16 @@ public async Task<AbstractExecutableTest> BuildTestAsync(TestMetadata metadata,
 
         // Invoke test registered event receivers BEFORE discovery event receivers
         // This is critical for allowing attributes to set custom hook executors
-        await InvokeTestRegisteredEventReceiversAsync(context);
+        try
+        {
+            await InvokeTestRegisteredEventReceiversAsync(context);
+        }
+        catch (Exception ex)
+        {
+            // Property registration or other registration logic failed
+            // Mark the test as failed immediately, as the old code did
+            test.SetResult(TestState.Failed, ex);
+        }
 
         await InvokeDiscoveryEventReceiversAsync(context);
 

TUnit.Engine/Services/TestArgumentRegistrationService.cs

@@ -5,12 +5,10 @@
 using TUnit.Core;
 using TUnit.Core.Data;
 using TUnit.Core.Enums;
-using TUnit.Core.Helpers;
 using TUnit.Core.Interfaces;
 using TUnit.Core.Interfaces.SourceGenerator;
 using TUnit.Core.PropertyInjection;
 using TUnit.Core.Tracking;
-using TUnit.Engine.Helpers;
 
 namespace TUnit.Engine.Services;
 
@@ -97,19 +95,6 @@ private async ValueTask RegisterPropertiesAsync(TestContext testContext)
                     // Create the data source for this property
                     var dataSource = metadata.CreateDataSource();
 
-                    // Create PropertyMetadata for MembersToGenerate
-                    var containingTypeMetadata = ClassMetadataHelper.GetOrCreateClassMetadata(metadata.ContainingType);
-                    var propMetadata = new PropertyMetadata
-                    {
-                        IsStatic = false,
-                        Name = metadata.PropertyName,
-                        ClassMetadata = containingTypeMetadata,
-                        Type = metadata.PropertyType,
-                        ReflectionInfo = PropertyHelper.GetPropertyInfo(metadata.ContainingType, metadata.PropertyName),
-                        Getter = parent => PropertyHelper.GetPropertyInfo(metadata.ContainingType, metadata.PropertyName).GetValue(parent!)!,
-                        ContainingTypeMetadata = containingTypeMetadata
-                    };
-
                     // Create minimal DataGeneratorMetadata for property resolution during registration
                     var testBuilderContext = new TestBuilderContext
                     {
@@ -122,7 +107,7 @@ private async ValueTask RegisterPropertiesAsync(TestContext testContext)
                     var dataGenMetadata = new DataGeneratorMetadata
                     {
                         TestBuilderContext = new TestBuilderContextAccessor(testBuilderContext),
-                        MembersToGenerate = [propMetadata], // Pass the property metadata
+                        MembersToGenerate = [], // Properties don't use member generation
                         TestInformation = testContext.TestDetails.MethodMetadata,
                         Type = DataGeneratorType.Property,
                         TestSessionId = TestSessionContext.Current?.Id ?? "registration",