-
-
Notifications
You must be signed in to change notification settings - Fork 102
Add DoesNotMatch assertion method for string regex validation #2305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks! Can you add some tests for positive and negative paths? |
yes absolutely! I was just unsure where to exactly place them, as to my knowledge the original |
|
Tests are running successfully locally, but had to do some |
|
Ah, I see Codacy has an issue on partial class, probably on the net framework flow as far as I can imagine, as the partial keyword isnt needed then. |
|
Don't worry about codacy - I can sort it later. You need to run the public API tests, which will fail, and then accept the new snapshots (instructions are here if you've not used verify: https://github.com/VerifyTests/Verify?tab=readme-ov-file#initial-verification) and then commit them |
|
Sorry, I had missed the net framework verify |
|
Thanks! |
Please check the following before creating a Pull Request
If this is a new feature or piece of functionality, have you started a discussion and gotten agreement on it?
Did you write tests to ensure you code works properly?