Skip to content

Conversation

Youssef1313
Copy link
Contributor

Please check the following before creating a Pull Request

  • If this is a new feature or piece of functionality, have you started a discussion and gotten agreement on it?
  • If it fixes a bug or problem, is there an issue to track it? If not, create one first and link it please so there's clear visibility.
  • Did you write tests to ensure you code works properly?

@thomhurst
Copy link
Owner

Thanks @Youssef1313 ! Sorry for the delay. Can you fix the conflicts please?

@thomhurst
Copy link
Owner

@claude could you rebase this PR and fix the conflicts?

Copy link
Contributor

claude bot commented Aug 13, 2025

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

@thomhurst
Copy link
Owner

@copilot can you rebase this PR?

Copy link
Contributor

claude bot commented Aug 13, 2025

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

public void Enable()
{
}
=> IsTrxEnabled = true;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this get called by the non-abstractions Trx package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It's not part of ITrxReportCapability interface. It's read in places that create the Trx-related messages so that they can be skipped if trx isn't enabled.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean what actually calls enable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants