-
-
Notifications
You must be signed in to change notification settings - Fork 93
Produce TRX properties only if Trx is enabled #2650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks @Youssef1313 ! Sorry for the delay. Can you fix the conflicts please? |
@claude could you rebase this PR and fix the conflicts? |
Claude encountered an error —— View job
I'll analyze this and get back to you. |
@copilot can you rebase this PR? |
Claude encountered an error —— View job
I'll analyze this and get back to you. |
public void Enable() | ||
{ | ||
} | ||
=> IsTrxEnabled = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this get called by the non-abstractions Trx package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. It's not part of ITrxReportCapability
interface. It's read in places that create the Trx-related messages so that they can be skipped if trx isn't enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean what actually calls enable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, Enable
itself is called by the Trx extension (the non-abstractions package):
1a27159
to
ec25436
Compare
Please check the following before creating a Pull Request