Add color input #2824
Open
Add color input #2824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coorasse
commented
Apr 3, 2025
Comment on lines
+95
to
+97
| [type="color"] { | ||
| padding: 0 0.5em; | ||
| } |
There was a problem hiding this comment.
the padding on top and bottom of 0.5em made the color in the input field basically disappear. I had to override it
coorasse
commented
Apr 3, 2025
| margin-right: 0.5em; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I am not sure this fits in this CSS file to be honest
coorasse
commented
Apr 3, 2025
spec/lib/fields/color_spec.rb
Outdated
There was a problem hiding this comment.
I probably could test more....but I added a field in the demo app 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
Field::Colorto render a color picker. It uses the HTML color picker input in the form and shows a small square with the color in the index and show.Form
Show
Index