Skip to content

Commit 8652deb

Browse files
committed
update RequiredNodesAreReady to get nodesNumber as argument
1 parent a7dceed commit 8652deb

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

integrationtests/k8s_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import (
1212
)
1313

1414
// RequireNodesAreReady runs `kubectl get node` on the master node and requires that all nodes are ready
15-
func RequireNodesAreReady(t *testing.T, terraformOptions *terraform.Options, privateKey string) {
15+
func RequireNodesAreReady(t *testing.T, terraformOptions *terraform.Options, privateKey string, nodesNumber int) {
1616
t.Helper()
1717

1818
masterYggIP := terraform.Output(t, terraformOptions, "mr_ygg_ip")
@@ -24,7 +24,6 @@ func RequireNodesAreReady(t *testing.T, terraformOptions *terraform.Options, pri
2424
output = strings.TrimSpace(output)
2525
require.NoError(t, err)
2626

27-
nodesNumber := 2
2827
numberOfReadyNodes := strings.Count(output, "Ready")
2928
fmt.Println(output)
3029
require.True(t, numberOfReadyNodes == nodesNumber, "number of ready nodes is not equal to number of nodes only %d nodes are ready", numberOfReadyNodes)
@@ -84,7 +83,7 @@ func TestK8s(t *testing.T) {
8483
require.True(t, ok)
8584

8685
// ssh to master node
87-
RequireNodesAreReady(t, terraformOptions, privateKey)
86+
RequireNodesAreReady(t, terraformOptions, privateKey, 2)
8887
})
8988

9089
t.Run("k8s_invalid_names", func(t *testing.T) {

integrationtests/k8s_using_module_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ func TestModuleK8s(t *testing.T) {
101101
require.NoError(t, err)
102102
defer terraform.Destroy(t, terraformOptions)
103103

104-
RequireNodesAreReady(t, terraformOptions, privateKey)
104+
RequireNodesAreReady(t, terraformOptions, privateKey, 2)
105105

106106
terraformOptions.Vars["workers"] = []map[string]interface{}{
107107
{
@@ -149,5 +149,5 @@ func TestModuleK8s(t *testing.T) {
149149
_, err = terraform.ApplyE(t, terraformOptions)
150150
require.NoError(t, err)
151151

152-
RequireNodesAreReady(t, terraformOptions, privateKey)
152+
RequireNodesAreReady(t, terraformOptions, privateKey, 3)
153153
}

0 commit comments

Comments
 (0)