Skip to content

use sets instead of lists in terraform schema #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mariobassem opened this issue Mar 26, 2023 · 1 comment
Open

use sets instead of lists in terraform schema #586

mariobassem opened this issue Mar 26, 2023 · 1 comment
Milestone

Comments

@mariobassem
Copy link
Collaborator

currently, lists are used in the provider's schema. any change to the order of the workloads in lists will result in unexpected behavior on the grid.

Instead, sets should be used to uniquely identify workloads not just by their place in a list.

@mariobassem mariobassem added this to the 2.0.0 milestone Mar 26, 2023
@ashraffouda ashraffouda self-assigned this Jun 8, 2023
@ashraffouda ashraffouda modified the milestones: 2.0.0, 1.9.1 Jun 8, 2023
@ashraffouda
Copy link
Collaborator

tried it with sets, it gave a weird behavior if for example have a 2 vms and modified one of them if shows that 4vms modified and need to deploy them, so we instead will use nestedMap feature in the new terraform framework, but this requires a lots of modifications to the current provider

@ashraffouda ashraffouda modified the milestones: 1.9.1, later Jun 15, 2023
@ashraffouda ashraffouda removed this from 3.11.x Jun 15, 2023
@ashraffouda ashraffouda removed their assignment Jun 15, 2023
@rawdaGastan rawdaGastan modified the milestones: later, future Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants