fix k8s using module test #955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslam-Nawara
force-pushed
the
fix-k8s-module-test
branch
11 times, most recently
from
aa6328d to
d4ea683
Compare
Eslam-Nawara
force-pushed
the
fix-k8s-module-test
branch
9 times, most recently
from
84706b0 to
401d062
Compare
Eslam-Nawara
force-pushed
the
fix-k8s-module-test
branch
from
401d062 to
a7dceed
Compare
Eslam-Nawara
force-pushed
the
fix-k8s-module-test
branch
from
8652deb to
e4bdc03
Compare
Eslam-Nawara
requested review from
mariobassem,
ashraffouda and
rawdaGastan
as code owners
Eslam-Nawara
requested review from
AlaaElattar,
AbdelrahmanElawady and
xmonader
as code owners
AbdelrahmanElawady
approved these changes
Jul 7, 2024
| @@ -22,7 +22,7 @@ func TestModuleK8s(t *testing.T) { | |||
|
|
|||
| */ | |||
|
|
|||
| t.Skip("https://github.com/threefoldtech/terraform-provider-grid/issues/770") | |||
| // t.Skip("https://github.com/threefoldtech/terraform-provider-grid/issues/770") | |||
There was a problem hiding this comment.
this should be removed
rawdaGastan
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix k8s using module test
Related Issues
Checklist