Skip to content

Multiple tags in tj-action/changed-files (one of the actions we are using) are compromised #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sameh-farouk opened this issue Mar 20, 2025 · 1 comment
Assignees

Comments

@sameh-farouk
Copy link
Member

sameh-farouk commented Mar 20, 2025

@sameh-farouk sameh-farouk self-assigned this Mar 20, 2025
@sameh-farouk
Copy link
Member Author

Update:
I checked and confirmed that we were not exposed to this attack.

  • The last time we ran this workflow (Generate benchmark weights), it was well ahead of the compromised time.

Image

Image
Image

To clarify:
The action name is simply a pointer to a GitHub repository under a GitHub organization.
the name prefixed by a @ represents the commit identifier. It is generally in the form of a tag @v3
actions/checkout@v3

In fact, a tag is simply a pointer to a specific SHA:

actions/checkout@v3 points to actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744

Both commit SHA and tags can be used as commit identifiers. The problem with GitHub tags is that they can be updated to point to other commits (hence open to such attacks).

@xmonader Should we start using commit SHAs vs GitHub tags and update the workflows in all of our repos?

@sameh-farouk sameh-farouk moved this to In Progress in 3.17 Mar 20, 2025
@sameh-farouk sameh-farouk moved this from In Progress to In Verification in 3.17 Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Verification
Development

No branches or pull requests

1 participant